tagged as 1.10.1

.semver_git_tag

@@ -1 +1 @@
-1.10.0
+1.10.1

Makefile

@@ -41,7 +41,7 @@ install_dev:
 #compile backend to Neko
 compile:
 	@if [ $(PLUGINS) = 1 ]; then \
-	echo "compile Cagette.net with plugins"; \
+	echo "compile CagettePéi plugins"; \
 	haxe cagetteAllPlugins.hxml; \
 	else \
 	echo "compile CagettePéi core"; \
@@ -74,7 +74,7 @@ templates:
 	@make LANG=fr ctemplates
 	msgfmt www/lang/texts_fr.po -o www/lang/texts_fr.mo 
 	chown www-data:www-data -R www
-	chown www-data:www-data -R lang
+	chown www-data:www-data -R lang/fr
 
 ctemplates:
 	(cd lang/$(LANG)/tpl; temploc2 -macros macros.mtt -output ../tmp/ *.mtt */*.mtt */*/*.mtt)

cagette.hxml

@@ -21,6 +21,7 @@
 -lib tink_streams:0.2.1
 -lib tink_syntaxhub:0.4.3
 -lib tink_typecrawler:0.7.0
+-lib thx.text:0.2.1
 
 ## GIT
 # -lib sugoi:git:https://git.artcode.re/cagetters/sugoi.git

js/react/user/LoginBox.hx

@@ -1,4 +1,5 @@
 package react.user;
+
 import react.ReactComponent;
 import react.ReactMacro.jsx;
 import Common;
@@ -19,23 +20,21 @@ typedef LoginBoxState = {
  * Login Box
  * @author fbarbut
  */
-class LoginBox extends react.ReactComponentOfPropsAndState<LoginBoxProps,LoginBoxState>
+class LoginBox extends react.ReactComponentOfPropsAndState<LoginBoxProps, LoginBoxState> {
-{
+	public function new(props:LoginBoxProps) {
+		if (props.redirectUrl == null)
+			props.redirectUrl = "/";
+		if (props.message == "")
+			props.message = null;
+		super(props);
+		this.state = {email: "", password: "", error: null};
+	}
 
-	public function new(props:LoginBoxProps) 
+	function setError(err:String) {
-	{
+		this.setState(cast {error: err});
-		if (props.redirectUrl == null) props.redirectUrl = "/";
-		if (props.message == "") props.message = null;
-		super(props);		
-		this.state = {email:"", password:"", error:null};
 	}
-	
+
-	function setError(err:String){
+	override public function render() {
-		this.setState(cast {error:err});
-	}
-	
-	override public function render(){
-		
 		return jsx('<div onKeyPress=$onKeyPress>
 			<$Error error="${state.error}" />
 			<$Message message="${props.message}" />
@@ -62,78 +61,75 @@ class LoginBox extends react.ReactComponentOfPropsAndState<LoginBoxProps,LoginBo
 			<!--
 			<hr/>
 			<p className="text-center">
-				<b>C\'est votre première visite sur Cagette.net ?</b>&nbsp;&nbsp;
+				<b>C\'est votre première visite sur CagettePéi ?</b>&nbsp;&nbsp;
 				<a onClick={registerBox} className="btn btn-default"><span className="glyphicon glyphicon-chevron-right"></span> S\'inscrire</a>
 			</p>
 			-->
 		</div>');
 	}
-	
+
 	/**
 	 * @doc https://facebook.github.io/react/docs/forms.html
 	 */
-	function onChange(e:js.html.Event){
+	function onChange(e:js.html.Event) {
 		e.preventDefault();
-		
+
-		var name :String = untyped e.target.name;
+		var name:String = untyped e.target.name;
-		var value :String = untyped /*(e.target.value == "") ? null :*/ e.target.value;
+		var value:String = untyped /*(e.target.value == "") ? null :*/ e.target.value;
 		Reflect.setField(state, name, value);
 		this.setState(this.state);
 	}
-	
+
 	/**
 	 * displays a registerBox
 	 */
-	public function registerBox(){
+	public function registerBox() {
-		
 		var body = js.Browser.document.querySelector('#myModal .modal-body');
-		ReactDOM.unmountComponentAtNode( body );
+		ReactDOM.unmountComponentAtNode(body);
-	
+
 		js.Browser.document.querySelector("#myModal .modal-title").innerHTML = "Inscription";
-		ReactDOM.render(jsx('<$RegisterBox redirectUrl="${props.redirectUrl}" phoneRequired="${props.phoneRequired}"/>'),  body );
+		ReactDOM.render(jsx('<$RegisterBox redirectUrl="${props.redirectUrl}" phoneRequired="${props.phoneRequired}"/>'), body);
 	}
-	
+
-	public function submit(?e:js.html.Event){
+	public function submit(?e:js.html.Event) {
-		
+		if (state.email == "") {
-		if (state.email == ""){
 			setError("Veuillez saisir votre email");
 			return;
 		}
-		if (state.password == ""){
+		if (state.password == "") {
 			setError("Veuillez saisir votre mot de passe");
 			return;
 		}
-		
+
-		//lock button
+		// lock button
-		var el: js.html.Element = null;
+		var el:js.html.Element = null;
-		if(e!=null){
+		if (e != null) {
 			el = cast e.target;
 			el.classList.add("disabled");
 		}
-	
+
-		
 		var req = new haxe.Http("/api/user/login");
 		req.addParameter("email", state.email);
 		req.addParameter("password", state.password);
 		req.addParameter("redirecturl", props.redirectUrl);
-		
+
-		req.onData = req.onError = function(d){
+		req.onData = req.onError = function(d) {
-			
 			var d = req.responseData;
-			
+
-			if(e!=null) el.classList.remove("disabled");
+			if (e != null)
-			
+				el.classList.remove("disabled");
+
 			var d = haxe.Json.parse(d);
-			if (Reflect.hasField(d, "error"))	setError(d.error.message);
+			if (Reflect.hasField(d, "error"))
-			if (Reflect.hasField(d, "success")) js.Browser.window.location.href = props.redirectUrl;
+				setError(d.error.message);
+			if (Reflect.hasField(d, "success"))
+				js.Browser.window.location.href = props.redirectUrl;
 		}
 		req.request(true);
 	}
 
-	function onKeyPress(e:js.html.KeyboardEvent){
+	function onKeyPress(e:js.html.KeyboardEvent) {
-		if(e.key=="Enter") submit();
+		if (e.key == "Enter")
+			submit();
 	}
-	
+}
-	
-	
-}

lang/master/tpl/base.mtt

@@ -11,7 +11,7 @@
 			::end::
 		</title>
 		
-		<!-- Cagette CSS -->
+		<!-- CagettePéi CSS -->
 		<link rel="stylesheet" type="text/css" href="/css/::getVariable('css')::/style.css"/>
 		<!--
 			<link rel="stylesheet" type="text/css" href="/css/::getVariable('css')::/shop.css"/>

lang/master/tpl/design.mtt

@@ -14,7 +14,7 @@
 					<h1>::groupName::</h1>
 				::else::
 					<div style="margin-bottom:22px;" >
-							<a href="https://git.artcode.re/cagetters/cagette" target="_blank">
+							<a href="https://git.artcode.re/cagetters/cagettepei" target="_blank">
 								<img src="/img/logo3.png" alt="::NAME::" />
 							</a>
 					</div>		
@@ -121,7 +121,7 @@
 		<!--<div class="row">
 			<div class="col-md-12 alert-danger text-center" style="border-radius: 8px;margin:8px 0;padding:8px 0;">
 				<span class="glyphicon glyphicon-cog"></span>
-				Attention : Cagette.net sera indisponible le <b>mardi 7 août de 9:00 à 11:00</b>.
+				Attention : CagettePéi sera indisponible le <b>mardi 7 août de 9:00 à 11:00</b>.
 				<br/>
 				Nous déménageons sur un nouveau serveur pour plus de rapidité et de fiabilité.
 			</div>

lang/master/tpl/messages/default.mtt

@@ -29,7 +29,7 @@
 <div class="col-md-9">
 	<div class="article">
 		<h3>::_("Send an e-mail")::</h3>		
-		
+
 		::raw form::
 	</div>
 </div>

package.json

@@ -47,5 +47,5 @@
   "bugs": {
     "url": "https://github.com/bablukid/cagette/issues"
   },
-  "version": "1.10.0"
+  "version": "1.10.1"
 }

src/App.hx

@@ -287,7 +287,7 @@ class App extends sugoi.BaseApp {
 		var e = new sugoi.mail.Mail();
 		e.setSubject(subject);
 		e.setRecipient(to);
-		e.setSender(App.config.get("default_email"), "Cagette.net");
+		e.setSender(App.config.get("default_email"), t._("Cagette.net"));
 		var html = App.current.processTemplate("mail/message.mtt", {text: html, group: group});
 		e.setHtmlBody(html);
 		App.sendMail(e);

src/controller/Cron.hx

@@ -77,7 +77,7 @@ class Cron extends Controller {
 			}
 
 			var m = new Mail();
-			m.setSender(App.config.get("default_email"), "Cagette.net");
+			m.setSender(App.config.get("default_email"), t._("Cagette.net"));
 			m.addRecipient(App.config.get("webmaster_email"));
 			m.setSubject(App.config.NAME + " Errors");
 			m.setHtmlBody(app.processTemplate("mail/message.mtt", {text: report.toString()}));
@@ -306,7 +306,7 @@ class Cron extends Controller {
 
 					try {
 						var m = new Mail();
-						m.setSender(App.config.get("default_email"), "Cagette.net");
+						m.setSender(App.config.get("default_email"), t._("Cagette.net"));
 						if (group.contact != null)
 							m.setReplyTo(group.contact.email, group.name);
 						m.addRecipient(u.user.email, u.user.getName());

src/controller/Messages.hx

@@ -41,11 +41,6 @@ class Messages extends Controller {
 			var subject = form.getValueOf("subject");
 
 			App.log('about to send email <$subject> to listId=<$listId> to ${dest.length} recipient(s)');
-			// Sys.command("sh", [
-			// 	"-c",
-			// 	"sendemail -f no-reply@comptoirduvrac.re -s mail1.zourit.net:587 -t pvincent@comptoirduvrac.re -bcc 'pvincent974@gmail.com, pvincent974@laposte.net' -u TEST -m coucou -xu postmaster@comptoirduvrac.re -xp QqQeAPT6EpoK"
-			// ]);
-
 			var mails = [];
 			for (d in dest) {
 				if (d.email != null)
@@ -56,7 +51,7 @@ class Messages extends Controller {
 
 			// send mail confirmation link
 			var e = new sugoi.mail.Mail();
-			e.setSender(App.config.get("default_email"));
+			e.setSender(App.config.get("default_email"), t._("Cagette.net"));
 			e.setSubject(subject);
 
 			var replyTo = form.getValueOf("senderMail");
@@ -64,20 +59,9 @@ class Messages extends Controller {
 			if (replyTo != null)
 				e.setReplyTo(replyTo, replyToName);
 
-			if (mails.length > 1) {
+			for (x in mails)
-				var cc = mails.join(",");
+				e.addRecipient(x);
-				App.log('add header Cc: $cc');
-				e.setHeader("CC:", cc);
-				// for (x in mails)
-				// 	e.addRecipient(x);
-				e.addRecipient(e.getSender().email);
-			} else {
-				App.log('no header');
-				e.addRecipient(mails[0]);
-			}
 
-			// sender : default email ( explicitly tells that the server send an email on behalf of the user )
-			// e.setHeader("Sender", App.config.get("default_email"));
 			var text:String = form.getValueOf("text");
 			var html = app.processTemplate("mail/message.mtt", {text: text, group: app.user.amap, list: getListName(listId)});
 			e.setHtmlBody(html);
@@ -98,6 +82,8 @@ class Messages extends Controller {
 			lm.insert();
 
 			throw Ok("/messages", t._("The message has been sent"));
+		} else {
+			App.log('Administrator #${app.user.id} <${senderName}> prepares sending an email from choices list');
 		}
 
 		view.form = form;

src/service/OrderService.hx

@@ -1,4 +1,5 @@
 package service;
+
 import Common;
 import tink.core.Error;
 
@@ -6,10 +7,8 @@ import tink.core.Error;
  * Order Service
  * @author web-wizard,fbarbut
  */
-class OrderService
+class OrderService {
-{
+	static function canHaveFloatQt(product:db.Product):Bool {
-
-	static function canHaveFloatQt(product:db.Product):Bool{
 		return product.hasFloatQt || product.wholesale || product.variablePrice;
 	}
 
@@ -20,42 +19,45 @@ class OrderService
 	 * @param	productId
 	 */
 	public static function make(user:db.User, quantity:Float, product:db.Product, ?distribId:Int, ?paid:Bool, ?user2:db.User, ?invert:Bool):db.UserContract {
-		
 		var t = sugoi.i18n.Locale.texts;
 
-		if(product.contract.type==db.Contract.TYPE_VARORDER && distribId==null) throw "You have to provide a distribId";
+		if (product.contract.type == db.Contract.TYPE_VARORDER && distribId == null)
-		if(quantity==null) throw "Quantity is null";
+			throw "You have to provide a distribId";
+		if (quantity == null)
+			throw "Quantity is null";
 
-		//quantity
+		// quantity
-		if ( !canHaveFloatQt(product) ){
+		if (!canHaveFloatQt(product)) {
-			if( !tools.FloatTool.isInt(quantity)  ) {
+			if (!tools.FloatTool.isInt(quantity)) {
-				throw new tink.core.Error(t._("Error : product \"::product::\" quantity should be integer",{product:product.name}));
+				throw new tink.core.Error(t._("Error : product \"::product::\" quantity should be integer", {product: product.name}));
 			}
 		}
-		
+
-		//multiweight : make one row per product
+		// multiweight : make one row per product
-		if (product.multiWeight && quantity > 1.0){
+		if (product.multiWeight && quantity > 1.0) {
-			if (product.multiWeight && quantity != Math.abs(quantity)) throw t._("multi-weighing products should be ordered only with integer quantities");
+			if (product.multiWeight && quantity != Math.abs(quantity))
-			
+				throw t._("multi-weighing products should be ordered only with integer quantities");
+
 			var o = null;
-			for ( i in 0...Math.round(quantity)){
+			for (i in 0...Math.round(quantity)) {
 				o = make(user, 1, product, distribId, paid, user2, invert);
-			}			
+			}
 			return o;
 		}
-		
+
-		//checks
+		// checks
-		if (quantity <= 0) return null;
+		if (quantity <= 0)
-		
+			return null;
-		//check for previous orders on the same distrib
+
+		// check for previous orders on the same distrib
 		var prevOrders = new List<db.UserContract>();
 		if (distribId == null) {
-			prevOrders = db.UserContract.manager.search($product==product && $user==user, true);
+			prevOrders = db.UserContract.manager.search($product == product && $user == user, true);
-		}else {
+		} else {
-			prevOrders = db.UserContract.manager.search($product==product && $user==user && $distributionId==distribId, true);
+			prevOrders = db.UserContract.manager.search($product == product && $user == user && $distributionId == distribId, true);
 		}
-		
+
-		//Create order object
+		// Create order object
 		var o = new db.UserContract();
 		o.product = product;
 		o.quantity = quantity;
@@ -66,214 +68,214 @@ class OrderService
 		o.user = user;
 		if (user2 != null) {
 			o.user2 = user2;
-			if (invert != null) o.flags.set(InvertSharedOrder);
+			if (invert != null)
+				o.flags.set(InvertSharedOrder);
 		}
-		if (paid != null) o.paid = paid;
+		if (paid != null)
-		if (distribId != null) o.distribution = db.Distribution.manager.get(distribId);
+			o.paid = paid;
-		
+		if (distribId != null)
-		//cumulate quantities if there is a similar previous order
+			o.distribution = db.Distribution.manager.get(distribId);
+
+		// cumulate quantities if there is a similar previous order
 		if (prevOrders.length > 0 && !product.multiWeight) {
 			for (prevOrder in prevOrders) {
-				//if (!prevOrder.paid) {
+				// if (!prevOrder.paid) {
-					o.quantity += prevOrder.quantity;
+				o.quantity += prevOrder.quantity;
-					prevOrder.delete();
+				prevOrder.delete();
-				//}
+				// }
 			}
 		}
-		
+
-		//create a basket object
+		// create a basket object
-		if (distribId != null){
+		if (distribId != null) {
 			var dist = o.distribution;
-			var basket = db.Basket.getOrCreate(user, dist.place, dist.date);			
+			var basket = db.Basket.getOrCreate(user, dist.place, dist.date);
-			o.basket = basket;			
+			o.basket = basket;
 		}
-		
+
 		o.insert();
-		
+
-		//Stocks
+		// Stocks
 		if (o.product.stock != null) {
 			var c = o.product.contract;
 			if (c.hasStockManagement()) {
-				//trace("stock for "+quantity+" x "+product.name);
+				// trace("stock for "+quantity+" x "+product.name);
 				if (o.product.stock == 0) {
 					if (App.current.session != null) {
-						App.current.session.addMessage(t._("There is no more '::productName::' in stock, we removed it from your order", {productName:o.product.name}), true);
+						App.current.session.addMessage(t._("There is no more '::productName::' in stock, we removed it from your order",
+							{productName: o.product.name}), true);
 					}
 					o.quantity -= quantity;
-					if ( o.quantity <= 0 ) {
+					if (o.quantity <= 0) {
 						o.delete();
-						return null;	
+						return null;
 					}
-				}else if (o.product.stock - quantity < 0) {
+				} else if (o.product.stock - quantity < 0) {
 					var canceled = quantity - o.product.stock;
 					o.quantity -= canceled;
 					o.update();
-					
+
 					if (App.current.session != null) {
-						var msg = t._("We reduced your order of '::productName::' to quantity ::oQuantity:: because there is no available products anymore", {productName:o.product.name, oQuantity:o.quantity});
+						var msg = t._("We reduced your order of '::productName::' to quantity ::oQuantity:: because there is no available products anymore",
+							{productName: o.product.name, oQuantity: o.quantity});
 						App.current.session.addMessage(msg, true);
 					}
 					o.product.lock();
 					o.product.stock = 0;
 					o.product.update();
-					App.current.event(StockMove({product:o.product, move:0 - (quantity - canceled) }));
+					App.current.event(StockMove({product: o.product, move: 0 - (quantity - canceled)}));
-					
+				} else {
-				}else {
 					o.product.lock();
 					o.product.stock -= quantity;
-					o.product.update();	
+					o.product.update();
-					App.current.event(StockMove({product:o.product, move:0 - quantity}));
+					App.current.event(StockMove({product: o.product, move: 0 - quantity}));
 				}
-			}	
+			}
 		}
 		return o;
 	}
 
-
 	/**
 	 * Edit an existing order (quantity)
 	 */
-	public static function edit(order:db.UserContract, newquantity:Float, ?paid:Bool , ?user2:db.User,?invert:Bool) {
+	public static function edit(order:db.UserContract, newquantity:Float, ?paid:Bool, ?user2:db.User, ?invert:Bool) {
-		
 		var t = sugoi.i18n.Locale.texts;
-		
+
 		order.lock();
-		
+
-		//quantity
+		// quantity
-		if (newquantity == null) newquantity = 0;
+		if (newquantity == null)
-		if ( !canHaveFloatQt(order.product) ){
+			newquantity = 0;
-			if( !tools.FloatTool.isInt(newquantity)  ) {
+		if (!canHaveFloatQt(order.product)) {
-				throw new tink.core.Error(t._("Error : product \"::product::\" quantity should be integer",{product:order.product.name}));
+			if (!tools.FloatTool.isInt(newquantity)) {
+				throw new tink.core.Error(t._("Error : product \"::product::\" quantity should be integer", {product: order.product.name}));
 			}
 		}
-		
+
-		//paid
+		// paid
 		if (paid != null) {
 			order.paid = paid;
-		}else {
+		} else {
-			if (order.quantity < newquantity) order.paid = false;	
+			if (order.quantity < newquantity)
+				order.paid = false;
 		}
-		
+
-		//shared order
+		// shared order
-		if (user2 != null){
+		if (user2 != null) {
-			order.user2 = user2;	
+			order.user2 = user2;
-			if (invert == true) order.flags.set(InvertSharedOrder);
+			if (invert == true)
-			if (invert == false) order.flags.unset(InvertSharedOrder);
+				order.flags.set(InvertSharedOrder);
-		}else{
+			if (invert == false)
+				order.flags.unset(InvertSharedOrder);
+		} else {
 			order.user2 = null;
 			order.flags.unset(InvertSharedOrder);
 		}
 
-		//stocks
+		// stocks
-		var e : Event = null;
+		var e:Event = null;
 		if (order.product.stock != null) {
 			var c = order.product.contract;
-			
-			if (c.hasStockManagement()) {
-				
-				if (newquantity < order.quantity) {
 
-					//on commande moins que prévu : incrément de stock						
+			if (c.hasStockManagement()) {
+				if (newquantity < order.quantity) {
+					// on commande moins que prévu : incrément de stock
 					order.product.lock();
-					order.product.stock +=  (order.quantity-newquantity);
+					order.product.stock += (order.quantity - newquantity);
-					e = StockMove({product:order.product, move:0 - (order.quantity-newquantity) });
+					e = StockMove({product: order.product, move: 0 - (order.quantity - newquantity)});
-					
+				} else {
-				}else {
+					// on commande plus que prévu : décrément de stock
-				
-					//on commande plus que prévu : décrément de stock
 					var addedquantity = newquantity - order.quantity;
-					
+
 					if (order.product.stock - addedquantity < 0) {
-						
+						// stock is not enough, reduce order
-						//stock is not enough, reduce order
 						newquantity = order.quantity + order.product.stock;
-						if( App.current.session!=null) App.current.session.addMessage(t._("We reduced your order of '::productName::' to quantity ::oQuantity:: because there is no available products anymore", {productName:order.product.name, oQuantity:newquantity}), true);
+						if (App.current.session != null)
-						
+							App.current.session.addMessage(t._("We reduced your order of '::productName::' to quantity ::oQuantity:: because there is no available products anymore",
-						e = StockMove({product:order.product, move: 0 - order.product.stock });
+								{
-						
+								productName: order.product.name,
+								oQuantity: newquantity
+							}), true);
+
+						e = StockMove({product: order.product, move: 0 - order.product.stock});
+
 						order.product.lock();
 						order.product.stock = 0;
-						
+					} else {
-					}else{
+						// stock is big enough
-						
-						//stock is big enough
 						order.product.lock();
 						order.product.stock -= addedquantity;
-						
+
-						e = StockMove({ product:order.product, move: 0 - addedquantity });
+						e = StockMove({product: order.product, move: 0 - addedquantity});
-					}					
+					}
-				}				
+				}
-				order.product.update();					
+				order.product.update();
-			}	
+			}
 		}
-		
+
-		//update order
+		// update order
 		if (newquantity == 0) {
-			order.quantity = 0;			
+			order.quantity = 0;
 			order.paid = true;
 			order.update();
-		}else {
+		} else {
 			order.quantity = newquantity;
-			order.update();				
+			order.update();
-		}	
+		}
 
-		App.current.event(e);	
+		App.current.event(e);
 
 		return order;
 	}
 
-
 	/**
 	 *  Delete an order
 	 */
 	public static function delete(order:db.UserContract) {
 		var t = sugoi.i18n.Locale.texts;
 
-		if(order==null) throw new Error(t._("This order has already been deleted."));
+		if (order == null)
-		
+			throw new Error(t._("This order has already been deleted."));
-		order.lock();
-		
-		if (order.quantity == 0) {
 
+		order.lock();
+
+		if (order.quantity == 0) {
 			var contract = order.product.contract;
 			var user = order.user;
 
-			//Amap Contract
+			// Amap Contract
-			if ( contract.type == db.Contract.TYPE_CONSTORDERS ) {
+			if (contract.type == db.Contract.TYPE_CONSTORDERS) {
-
 				order.delete();
 
-				if( contract.amap.hasPayments() ){
+				if (contract.amap.hasPayments()) {
 					var orders = contract.getUserOrders(user);
-					if( orders.length == 0 ){
+					if (orders.length == 0) {
 						var operation = db.Operation.findCOrderTransactionFor(contract, user);
-						if(operation!=null) operation.delete();
+						if (operation != null)
+							operation.delete();
 					}
 				}
-			}
+			} else { // Variable orders contract
-			else { //Variable orders contract
+
-				
+				// Get the basket for this user
-				//Get the basket for this user
 				var place = order.distribution.place;
 				var basket = db.Basket.get(user, place, order.distribution.date);
-				
-				if( contract.amap.hasPayments() ){
-					var orders = basket.getOrders();
-					//Check if it is the last order, if yes then delete the related operation
-					if( orders.length == 1 && orders.first().id==order.id ){
-						var operation = db.Operation.findVOrderTransactionFor(order.distribution.getKey(), user, place.amap);
-						if(operation!=null) operation.delete();
-					}
 
+				if (contract.amap.hasPayments()) {
+					var orders = basket.getOrders();
+					// Check if it is the last order, if yes then delete the related operation
+					if (orders.length == 1 && orders.first().id == order.id) {
+						var operation = db.Operation.findVOrderTransactionFor(order.distribution.getKey(), user, place.amap);
+						if (operation != null)
+							operation.delete();
+					}
 				}
 
 				order.delete();
 			}
-		}
+		} else {
-		else {
 			throw new Error(t._("Deletion not possible: quantity is not zero."));
 		}
-
 	}
 
 	/**
@@ -285,21 +287,20 @@ class OrderService
 		var view = App.current.view;
 		var t = sugoi.i18n.Locale.texts;
 		for (o in orders) {
-		
+			var x:UserOrder = cast {};
-			var x : UserOrder = cast { };
 			x.id = o.id;
 			x.userId = o.user.id;
 			x.userName = o.user.getCoupleName();
 			x.userEmail = o.user.email;
-			
+
-			//shared order
+			// shared order
-			if (o.user2 != null){
+			if (o.user2 != null) {
 				x.userId2 = o.user2.id;
 				x.userName2 = o.user2.getCoupleName();
 				x.userEmail2 = o.user2.email;
 			}
-			
+
-			//deprecated
+			// deprecated
 			x.productId = o.product.id;
 			x.productRef = o.product.ref;
 			x.productQt = o.product.qt;
@@ -308,161 +309,160 @@ class OrderService
 			x.productImage = o.product.getImage();
 			x.productHasFloatQt = o.product.hasFloatQt;
 			x.productHasVariablePrice = o.product.variablePrice;
-			//new way
+			// new way
 			x.product = o.product.infos();
-			x.product.price = o.productPrice;//do not use current price, but price of the order
+			x.product.price = o.productPrice; // do not use current price, but price of the order
 
-			
 			x.quantity = o.quantity;
-			
+
-			//smartQt
+			// smartQt
-			if (x.quantity == 0.0){
+			if (x.quantity == 0.0) {
 				x.smartQt = t._("Canceled");
-			}else if(x.productHasFloatQt || x.productHasVariablePrice || o.product.wholesale){
+			} else if (x.productHasFloatQt || x.productHasVariablePrice || o.product.wholesale) {
 				x.smartQt = view.smartQt(x.quantity, x.productQt, x.productUnit);
-			}else{
+			} else {
 				x.smartQt = Std.string(x.quantity);
 			}
 
-			//product name.
+			// product name.
-			if ( x.productHasVariablePrice || x.productQt==null || x.productUnit==null ){
+			if (x.productHasVariablePrice || x.productQt == null || x.productUnit == null) {
-				x.productName = o.product.name;	
+				x.productName = o.product.name;
-			}else{
+			} else {
-				x.productName = o.product.name + " " + view.formatNum(x.productQt) +" "+ view.unit(x.productUnit,x.productQt>1);	
+				x.productName = o.product.name + " " + view.formatNum(x.productQt) + " " + view.unit(x.productUnit, x.productQt > 1);
 			}
-			
+
 			x.subTotal = o.quantity * o.productPrice;
 
 			var c = o.product.contract;
-			
+
-			if ( o.feesRate!=0 ) {
+			if (o.feesRate != 0) {
-				
+				x.fees = x.subTotal * (o.feesRate / 100);
-				x.fees = x.subTotal * (o.feesRate/100);
 				x.percentageName = c.percentageName;
 				x.percentageValue = o.feesRate;
 				x.total = x.subTotal + x.fees;
-				
+			} else {
-			}else {
 				x.total = x.subTotal;
 			}
-			
+
-			//flags
+			// flags
 			x.paid = o.paid;
 			x.invertSharedOrder = o.flags.has(InvertSharedOrder);
 			x.contractId = c.id;
 			x.contractName = c.name;
-			x.canModify = o.canModify(); 
+			x.canModify = o.canModify();
-			
+
 			out.push(x);
 		}
-		
+
 		return sort(out);
 	}
-	
+
 	/**
 	 * Confirms an order : create real orders from tmp orders in session
 	 * @param	order
 	 */
-	public static function confirmSessionOrder(tmpOrder:OrderInSession){
+	public static function confirmSessionOrder(tmpOrder:OrderInSession) {
 		var orders = [];
 		var user = db.User.manager.get(tmpOrder.userId);
-		for (o in tmpOrder.products){
+		for (o in tmpOrder.products) {
 			o.product = db.Product.manager.get(o.productId);
-			orders.push( make(user, o.quantity, o.product, o.distributionId) );
+			orders.push(make(user, o.quantity, o.product, o.distributionId));
 		}
-		
+
 		App.current.event(MakeOrder(orders));
-		App.current.session.data.order = null;	
+		App.current.session.data.order = null;
-		
+
 		return orders;
 	}
 
-
 	/**
 	 *  Send an order-by-products report to the coordinator
 	 */
-	public static function sendOrdersByProductReport(d:db.Distribution){
+	public static function sendOrdersByProductReport(d:db.Distribution) {
-		
+		var t = sugoi.i18n.Locale.texts;
+
 		var m = new sugoi.mail.Mail();
-		m.addRecipient(d.contract.contact.email , d.contract.contact.getName());
+		m.addRecipient(d.contract.contact.email, d.contract.contact.getName());
-		m.setSender(App.config.get("default_email"),"Cagette.net");
+		m.setSender(App.config.get("default_email"), t._("Cagette.net"));
 		m.setSubject('[${d.contract.amap.name}] Distribution du ${App.current.view.dDate(d.date)} (${d.contract.name})');
 		var orders = service.ReportService.getOrdersByProduct(d);
 
-		var html = App.current.processTemplate("mail/ordersByProduct.mtt", { 
+		var html = App.current.processTemplate("mail/ordersByProduct.mtt", {
-			contract:d.contract,
+			contract: d.contract,
-			distribution:d,
+			distribution: d,
-			orders:orders,
+			orders: orders,
-			formatNum:App.current.view.formatNum,
+			formatNum: App.current.view.formatNum,
-			currency:App.current.view.currency,
+			currency: App.current.view.currency,
-			dDate:App.current.view.dDate,
+			dDate: App.current.view.dDate,
-			hHour:App.current.view.hHour,
+			hHour: App.current.view.hHour,
-			group:d.contract.amap
+			group: d.contract.amap
-		} );
+		});
-		
+
 		m.setHtmlBody(html);
-		App.sendMail(m);					
+		App.sendMail(m);
-
 	}
 
-
 	/**
 	 *  Order summary for a member
 	 *  WARNING : its for one distrib, not for a whole basket !
 	 */
-	public static function sendOrderSummaryToMembers(d:db.Distribution){
+	public static function sendOrderSummaryToMembers(d:db.Distribution) {
-
+		var t = sugoi.i18n.Locale.texts;
 		var title = '[${d.contract.amap.name}] Votre commande pour le ${App.current.view.dDate(d.date)} (${d.contract.name})';
 
-		for( user in d.getUsers() ){
+		for (user in d.getUsers()) {
-
 			var m = new sugoi.mail.Mail();
-			m.addRecipient(user.email , user.getName(),user.id);
+			m.addRecipient(user.email, user.getName(), user.id);
-			if(user.email2!=null) m.addRecipient(user.email2 , user.getName(),user.id);
+			if (user.email2 != null)
-			m.setSender(App.config.get("default_email"),"Cagette.net");
+				m.addRecipient(user.email2, user.getName(), user.id);
+			m.setSender(App.config.get("default_email"), t._("Cagette.net"));
 			m.setSubject(title);
-			var orders = prepare(d.contract.getUserOrders(user,d));
+			var orders = prepare(d.contract.getUserOrders(user, d));
+
+			var html = App.current.processTemplate("mail/orderSummaryForMember.mtt", {
+				contract: d.contract,
+				distribution: d,
+				orders: orders,
+				formatNum: App.current.view.formatNum,
+				currency: App.current.view.currency,
+				dDate: App.current.view.dDate,
+				hHour: App.current.view.hHour,
+				group: d.contract.amap
+			});
 
-			var html = App.current.processTemplate("mail/orderSummaryForMember.mtt", { 
-				contract:d.contract,
-				distribution:d,
-				orders:orders,
-				formatNum:App.current.view.formatNum,
-				currency:App.current.view.currency,
-				dDate:App.current.view.dDate,
-				hHour:App.current.view.hHour,
-				group:d.contract.amap
-			} );
-			
 			m.setHtmlBody(html);
 			App.sendMail(m);
 		}
-		
 	}
 
-	
+	public static function sort(orders:Array<UserOrder>) {
-
+		// order by lastname (+lastname2 if exists), then contract
-	public static function sort(orders:Array<UserOrder>){
-		
-		//order by lastname (+lastname2 if exists), then contract
 		orders.sort(function(a, b) {
-			
+			if (a.userName
-			if (a.userName + a.userId + a.userName2 + a.userId2 + a.contractId > b.userName + b.userId + b.userName2 + b.userId2 + b.contractId ) {
+				+ a.userId
-				
+				+ a.userName2
+				+ a.userId2
+				+ a.contractId > b.userName
+					+ b.userId
+					+ b.userName2
+					+ b.userId2
+					+ b.contractId) {
 				return 1;
 			}
-			if (a.userName + a.userId + a.userName2 + a.userId2 + a.contractId < b.userName + b.userId + b.userName2 + b.userId2 + b.contractId ) {
+			if (a.userName
-				 
+				+ a.userId
+				+ a.userName2
+				+ a.userId2
+				+ a.contractId < b.userName
+					+ b.userId
+					+ b.userName2
+					+ b.userId2
+					+ b.contractId) {
 				return -1;
 			}
 			return 0;
 		});
-		
+
 		return orders;
 	}
-	
+}
-	
-
-
-	
-}

src/sugoi/mail/Mail.hx

@@ -1,45 +1,53 @@
 package sugoi.mail;
+
 using Lambda;
 
-class Mail implements IMail
+class Mail implements IMail {
-{
+	public var title:String;
-	
+	public var htmlBody:String;
-	public var title : String;
+	public var textBody:String;
-	public var htmlBody : String;
+
-	public var textBody : String;
+	var headers:Map<String, String>;
-	var headers : Map<String,String>;
+	var sender:{name:String, email:String, ?userId:Int};
-	var sender : {name:String,email:String,?userId:Int};
+	var recipients:Array<{name:String, email:String, ?userId:Int}>;
-	var recipients : Array<{name:String,email:String,?userId:Int}>;
+
-	
+	static public function fromString(name:String, email:String) {
-	
+		if (name == null)
-	
+			return email;
+		else {
+			var finalName = thx.text.Diactrics.clean(name);
+			return '${finalName} <${email}>';
+		}
+	}
+
 	public function new() {
 		recipients = [];
 		headers = new Map();
 	}
-	
+
-	public function getRecipients(){
+	public function getRecipients() {
 		return recipients;
 	}
-	
+
-	public function setSender(email, ?name,?userId) {
+	public function setSender(email, ?name, ?userId) {
-		if(!isValid(email)) throw "invalid sender email : \""+email+"\"";
+		if (!isValid(email))
-		
+			throw "invalid sender email : \"" + email + "\"";
-		sender = {name:name,email:email,userId:userId};		
+
+		sender = {name: name, email: email, userId: userId};
 		return this;
 	}
-	
+
 	public function setReplyTo(email, ?name) {
-		if(!isValid(email)) throw "invalid reply-to email : \""+email+"\"";
+		if (!isValid(email))
-		
+			throw "invalid reply-to email : \"" + email + "\"";
-		setHeader("Reply-To","<"+email+">"+(name==null?"":name));
+		setHeader("Reply-To", fromString(name, email));
 	}
-	
+
 	public function setSubject(s:String) {
 		title = s;
 		return this;
 	}
-	
+
 	/**
 	 * can add one or more recipient
 	 * @param	email
@@ -47,11 +55,12 @@ class Mail implements IMail
 	 * @param	?userId
 	 */
 	public function addRecipient(email:String, ?name:String, ?userId:Int) {
-		if(!isValid(email)) throw "invalid recipient \""+email+"\"";
+		if (!isValid(email))
-		recipients.push( {email:email, name:name, userId:userId } );
+			throw "invalid recipient \"" + email + "\"";
+		recipients.push({email: email, name: name, userId: userId});
 		return this;
 	}
-	
+
 	/**
 	 * alias to addRecipient()
 	 * @param	email
@@ -62,24 +71,24 @@ class Mail implements IMail
 		addRecipient(email, name, userId);
 		return this;
 	}
-	
+
-	public static function isValid( addr : String ){
+	public static function isValid(addr:String) {
 		var reg = ~/^[^()<>@,;:\\"\[\]\s[:cntrl:]]+@[A-Z0-9][A-Z0-9-]*(\.[A-Z0-9][A-Z0-9-]*)*\.(xn--[A-Z0-9]+|[A-Z]{2,8})$/i;
 		return addr != null && reg.match(addr);
 	}
-	
+
 	public function setHeader(k:String, v:String) {
 		headers.set(k, v);
 		return this;
 	}
-	
+
 	/**
 	 * generate a custom key for transactionnal emails, valid during the current day
 	 */
 	public function getKey() {
-		return haxe.crypto.Md5.encode(App.config.get("key")+recipients[0].email+(Date.now().getDate())).substr(0,12);
+		return haxe.crypto.Md5.encode(App.config.get("key") + recipients[0].email + (Date.now().getDate())).substr(0, 12);
 	}
-	
+
 	/**
 	 * render html from a template + vars
 	 * @param	tpl		A Template path
@@ -88,7 +97,8 @@ class Mail implements IMail
 	public function setHtmlBodyWithTemplate(tpl, ctx:Dynamic) {
 		var app = App.current;
 		var tpl = app.loadTemplate(tpl);
-		if( ctx == null ) ctx = { };
+		if (ctx == null)
+			ctx = {};
 		ctx.HOST = App.config.HOST;
 		ctx.key = getKey();
 		ctx.senderName = sender.name;
@@ -98,28 +108,27 @@ class Mail implements IMail
 		ctx.recipients = recipients;
 		CSSInlining(ctx);
 		htmlBody = tpl.execute(ctx);
-		
 	}
-	
+
 	public function setHtmlBody(s) {
 		htmlBody = s;
 		return this;
 	}
-	
+
-	public function setTextBodyWithTemplate(tpl, ctx:Dynamic) {		
+	public function setTextBodyWithTemplate(tpl, ctx:Dynamic) {
 		var app = App.current;
 		var tpl = app.loadTemplate(tpl);
-		if( ctx == null ) ctx = { };
+		if (ctx == null)
+			ctx = {};
 		ctx.HOST = App.config.HOST;
 		ctx.key = getKey();
 		textBody = tpl.execute(ctx);
 		return this;
 	}
-	
 
 	function CSSInlining(ctx) {
 		// CSS inlining
-		var css : Map<String,Array<String>> = new Map();
+		var css:Map<String, Array<String>> = new Map();
 		ctx.addStyle = function(sel:String, style:String) {
 			sel = sel.toLowerCase();
 			if (css.exists(sel))
@@ -130,11 +139,11 @@ class Mail implements IMail
 		}
 		var applyStyleRec = null;
 		applyStyleRec = function(x:Xml) {
-			if (x.nodeType==Xml.Element) {
+			if (x.nodeType == Xml.Element) {
 				var name = x.nodeName.toLowerCase();
-				if( css.exists(name) )
+				if (css.exists(name))
-					if (x.get("style")!=null)
+					if (x.get("style") != null)
-						x.set("style", x.get("style")+";"+css.get(name).join(";"));
+						x.set("style", x.get("style") + ";" + css.get(name).join(";"));
 					else
 						x.set("style", css.get(name).join(";"));
 				for (n in x)
@@ -143,40 +152,38 @@ class Mail implements IMail
 		}
 		ctx.applyStyle = function(raw:String) {
 			var x = Xml.parse(raw);
-			for(n in x)
+			for (n in x)
 				applyStyleRec(n);
 			return x.toString();
 		}
 	}
-	
+
-	
+	public function getSubject() {
-	public function getSubject(){
 		return title;
 	}
 
-	public function getTitle(){
+	public function getTitle() {
 		return getSubject();
 	}
-	
+
-	public function getHtmlBody(){
+	public function getHtmlBody() {
 		return htmlBody;
 	}
-	
+
-	public function getTextBody(){
+	public function getTextBody() {
 		return textBody;
 	}
-	
+
-	public function setTextBody(t){
+	public function setTextBody(t) {
 		textBody = t;
 		return this;
 	}
-	
+
-	public function getHeaders(){
+	public function getHeaders() {
 		return headers;
 	}
-	
+
-	public function getSender(){
+	public function getSender() {
 		return sender;
 	}
-	
+}
-}

src/sugoi/mail/SendEmailMailer.hx

@@ -41,52 +41,66 @@ class SendEmailMailer implements IMailer {
 	}
 
 	public function send(e:sugoi.mail.IMail, ?params:Dynamic, ?callback:MailerResult->Void) {
-		var mailServer = "mail1.zourit.net";
+		var to:String;
-		var mailPort = 587;
+		var bcc:String;
 
-		var fromName = "John Doe";
+		var recipientCounts = e.getRecipients().length;
-		var fromEmail = "no-reply@comptoirduvrac.re";
+		if (recipientCounts > 1) {
+			to = sugoi.mail.Mail.fromString(e.getSender().name, e.getSender().email);
+			bcc = [for (i in e.getRecipients()) i.email].join(",");
+			App.log('recipients has been transformed to ${recipientCounts} bcc');
+			App.log(bcc);
+		} else {
+			to = e.getRecipients()[0].email;
+			bcc = "";
+		}
 
 		var args = [
-			"-f",
+			// arguments
-			'${fromName} <${fromEmail}>',
 			"-s",
-			"mail1.zourit.net:587",
+			'${this.m.host}:${this.m.port}',
+			"-xu",
+			${this.m.auth.username},
+			"-xp",
+			${this.m.auth.password},
+			"-o",
+			"message-charset=utf-8",
+			"-o",
+			"message-format=html",
+			"-o",
+			"message-header=X-Mailer: CagettePei",
+			"-f",
+			sugoi.mail.Mail.fromString(e.getSender().name, e.getSender().email),
 			"-t",
-			"pvincent@comptoirduvrac.re",
+			to,
-			// "-bcc",		"pvincent974@gmail.com,pvincent974@laposte.net",
+			"-bcc",
+			bcc,
 			"-u",
 			e.getSubject(),
-			"-m",
-			"alors tout va bien",
-			"-xu",
-			"postmaster@comptoirduvrac.re",
-			"-xp",
-			"QqQeAPT6EpoK"
 		];
 
-		App.log('args=${args.join(" ")}');
+		// FIME: deal with replyTo
+		if (e.getHeaders().exists("Reply-To")) {
+			var replyTo = e.getHeaders()["Reply-To"];
+			App.log('replyTo "$replyTo" detected');
+			args.push("-o");
+			args.push('message-header=Reply-To: ${replyTo}');
+		}
+
+		args.push("-m");
+		args.push('<html>${e.getHtmlBody()}</html>');
+
+		// if (App.config.DEBUG)
+		// 	App.log('args=${args.join(" ")}');
 
 		var exitCode = Sys.command("sendemail", args);
 		// var exitCode = 0;
 
+		var summary = 'email from="${sugoi.mail.Mail.fromString(e.getSender().name, e.getSender().email)}" subject=<${e.getSubject()}>';
 		if (exitCode == 0)
-			App.log('email from="${e.getSender().name} <${e.getSender().email}"> subject=<${e.getSubject()}> successfully sent');
+			App.log('$summary successfully sent');
 		else
-			App.log('ERROR: email from="${e.getSender().name} <${e.getSender().email}"> subject=<${e.getSubject()}> cannot be sent');
+			App.log('ERROR: $summary cannot be sent, please review logs');
-
-		// sys.io.File.saveContent('/tmp/my_file.json', "CONTENT");
-
-		// var surprise = m.send({
-		// 	subject: e.getSubject(),
-		// 	from: new Address({address: e.getSender().email}),
-		// 	to: Lambda.array(Lambda.map(e.getRecipients(), function(x) return new Address({address: x.email}))),
-		// 	headers: e.getHeaders(),
-		// 	content: {
-		// 		text: e.getTextBody(),
-		// 		html: e.getHtmlBody()
-		// 	}
-		// });
 
 		if (callback != null) {
 			var map = new MailerResult();

src/sugoi/mail/SmtpMailer.hx

@@ -1,68 +0,0 @@
-package sugoi.mail;
-import tink.core.Future;
-import tink.core.Noise;
-import sugoi.mail.IMailer;
-import smtpmailer.Address;
-
-/**
- * Send emails thru SMTP by using ben merckx's library 
- * @ref https://github.com/benmerckx/smtpmailer
- */
-class SmtpMailer implements IMailer
-{
-	var m : smtpmailer.SmtpMailer;
-	
-	public function new(){}
-	
-	public function init(?conf:{smtp_host:String,smtp_port:Int,smtp_user:String,smtp_pass:String}) :IMailer
-	{
-		m = new smtpmailer.SmtpMailer({
-			host: conf.smtp_host,
-			port: conf.smtp_port,
-			auth: {
-				username: conf.smtp_user,
-				password: conf.smtp_pass
-			}
-		});
-		
-		return this;
-	}
-	
-	public function send(e:sugoi.mail.IMail,?params:Dynamic,?callback:MailerResult->Void) 
-	{
-		var surprise = m.send({
-			subject: e.getSubject(),
-			/*from: e.getSender().email,
-			to: Lambda.array(Lambda.map(e.getRecipients(), function(x) return smtpmailer.Address.ofString(x.email) )),
-			//headers : e.getHeaders(),*/
-			from: new Address({address:e.getSender().email}),
-			to: Lambda.array(Lambda.map(e.getRecipients(), function(x) return new Address({address:x.email}) )),
-			headers : e.getHeaders(),
-			content: {
-				text: e.getTextBody(),
-				html: e.getHtmlBody()
-			}/*,
-			attachments: []*/
-		});
-		
-			
-		if (callback != null){
-			
-			surprise.handle(function(s){
-				
-				var map = new MailerResult();
-				
-				switch(s){
-					case Success(_):
-						map.set("*",Success(Sent));
-						
-					case Failure(e):
-						map.set("*",Failure(GenericError(e)));
-				}
-				
-				callback(map);
-			});
-		}
-	}
-	
-}