From ac8255e482d61ea6f4e23c86baf45455e624db1b Mon Sep 17 00:00:00 2001
From: pvincent <pvincent@artcode.re>
Date: Thu, 18 Jan 2024 12:46:15 +0400
Subject: [PATCH] rubocop pending features

---
 .rubocop.yml                         |  2 ++
 .vscode/settings.json                |  3 ++-
 app/controllers/scores_controller.rb | 11 ++++-------
 app/helpers/application_helper.rb    |  1 +
 app/helpers/scores_helper.rb         |  2 --
 5 files changed, 9 insertions(+), 10 deletions(-)
 delete mode 100644 app/helpers/scores_helper.rb

diff --git a/.rubocop.yml b/.rubocop.yml
index c4e4390..567143d 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,2 +1,4 @@
 Style/FrozenStringLiteralComment:
   Enabled: false
+AllCops:
+  NewCops: enable
diff --git a/.vscode/settings.json b/.vscode/settings.json
index 0acec68..3228fdf 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -10,5 +10,6 @@
   },
   "emmet.includeLanguages": {
     "erb": "html"
-  }
+  },
+  "rubyLsp.enableExperimentalFeatures": true
 }
\ No newline at end of file
diff --git a/app/controllers/scores_controller.rb b/app/controllers/scores_controller.rb
index a7d3cb8..dabb1b4 100644
--- a/app/controllers/scores_controller.rb
+++ b/app/controllers/scores_controller.rb
@@ -6,14 +6,11 @@ class ScoresController < ApplicationController
   def index
     @scores = Score.all
     logger.debug 'this is a debug message'
-    logger.debug({ 'one': 1, 'two': 2 })
-    logger.info 'this is an information', { 'four': 4, 'five': 5 }
-    logger.info 'this is an object', BigDecimal('0.0001')
-    logger.warn 'this is a warning'
-    logger.error 'this is an error', BigDecimal('0.0002')
+    logger.debug({ one: 1, two: 2 })
+    logger.info 'this is an information', { four: 4, five: 5 }
     logger.debug BigDecimal('0.0003')
-    logger.debug 'scores are', @scores
-    logger.debug @scores
+    # logger.debug 'scores are', @scores
+    # logger.debug @scores
   end
 
   # GET /scores/1
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index de6be79..0903282 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -1,2 +1,3 @@
+# global helper
 module ApplicationHelper
 end
diff --git a/app/helpers/scores_helper.rb b/app/helpers/scores_helper.rb
deleted file mode 100644
index 26a3934..0000000
--- a/app/helpers/scores_helper.rb
+++ /dev/null
@@ -1,2 +0,0 @@
-module ScoresHelper
-end