From af7088788a8aea168a7de07af8f144c253222801 Mon Sep 17 00:00:00 2001 From: pvincent Date: Fri, 20 Sep 2024 23:22:11 +0400 Subject: [PATCH] instrumentalizer no more global variable --- config/initializers/instrumentalizing.rb | 2 -- lib/live/definable.rb | 1 + lib/semantic/instrumentalizer.rb | 8 ++++++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/config/initializers/instrumentalizing.rb b/config/initializers/instrumentalizing.rb index 3fe5d70..1b4b058 100644 --- a/config/initializers/instrumentalizing.rb +++ b/config/initializers/instrumentalizing.rb @@ -1,5 +1,3 @@ -return if Rails.application.tailwind_watcher? - return unless Rails.application.server? if Rails.env.development? diff --git a/lib/live/definable.rb b/lib/live/definable.rb index af5cddf..aa1f6e8 100644 --- a/lib/live/definable.rb +++ b/lib/live/definable.rb @@ -1,5 +1,6 @@ require 'dotenv' +# FIXME: do not use global variable $definable_thread_group ||= ThreadGroup.new module Live diff --git a/lib/semantic/instrumentalizer.rb b/lib/semantic/instrumentalizer.rb index cd98ee0..2ba3e91 100644 --- a/lib/semantic/instrumentalizer.rb +++ b/lib/semantic/instrumentalizer.rb @@ -16,10 +16,14 @@ module Semantic private - def global_subscribers = $global_subscribers ||= [] # rubocop:disable Style/GlobalVars + def global_subscribers + @global_subscribers ||= [] + end def reset - global_subscribers.each { |sub| ActiveSupport::Notifications.unsubscribe(sub) } + global_subscribers.each do |sub| + ActiveSupport::Notifications.unsubscribe(sub) + end global_subscribers.clear NOTIFICATIONS.each do |event_group, hooks|