From f3309f5bf51bc217c40b668cb8892831c9f4bd4a Mon Sep 17 00:00:00 2001 From: pvincent Date: Thu, 19 Sep 2024 21:54:25 +0400 Subject: [PATCH] log_subscriber simplified --- lib/live/definable.rb | 2 +- lib/semantic/subscribers/action_controller.rb | 3 ++- lib/semantic/subscribers/action_view.rb | 5 +---- lib/semantic/subscribers/log_subscriber.rb | 7 ++++--- 4 files changed, 8 insertions(+), 9 deletions(-) diff --git a/lib/live/definable.rb b/lib/live/definable.rb index 6f5f1c6..af5cddf 100644 --- a/lib/live/definable.rb +++ b/lib/live/definable.rb @@ -84,7 +84,7 @@ module Live value = typed_value(type, raw_value, default) definitions[constant] = { type:, default:, value: } - puts("-- new definition #{constant}:#{definitions[constant]}") + # puts("-- new definition #{constant}:#{definitions[constant]}") value end diff --git a/lib/semantic/subscribers/action_controller.rb b/lib/semantic/subscribers/action_controller.rb index dbb0d11..bff15c3 100644 --- a/lib/semantic/subscribers/action_controller.rb +++ b/lib/semantic/subscribers/action_controller.rb @@ -1,5 +1,6 @@ module Semantic module Subscribers + # LogSubscriber for event_group :action_controller class ActionController < LogSubscriber include AnsiColors @@ -8,9 +9,9 @@ module Semantic TERMINUS_STRING = '╙─╜'.freeze def initialize(session_key) + super() @session_key = session_key @transactions = {} - super(:action_controller) end def start_processing(event) diff --git a/lib/semantic/subscribers/action_view.rb b/lib/semantic/subscribers/action_view.rb index 02e76a4..4308ad4 100644 --- a/lib/semantic/subscribers/action_view.rb +++ b/lib/semantic/subscribers/action_view.rb @@ -1,5 +1,6 @@ module Semantic module Subscribers + # LogSubscriber for event_group :action_view class ActionView < LogSubscriber include AnsiColors @@ -7,10 +8,6 @@ module Semantic attr_reader :logger - def initialize - super(:action_view) - end - def render_partial(event) identifier = pathname(event.payload[:identifier]) # logger.debug("Rendered partial #{identifier}", event.payload[:locals]) if identifier diff --git a/lib/semantic/subscribers/log_subscriber.rb b/lib/semantic/subscribers/log_subscriber.rb index f407ca3..b4e2096 100644 --- a/lib/semantic/subscribers/log_subscriber.rb +++ b/lib/semantic/subscribers/log_subscriber.rb @@ -1,11 +1,12 @@ module Semantic module Subscribers + # Abstract LogSubscriber class LogSubscriber attr_reader :logger, :event_group - def initialize(event_group) - @event_group = event_group - @logger = SemanticLogger[event_group.to_s] + def initialize + @event_group = self.class.name.demodulize.underscore.to_sym + @logger = SemanticLogger[@event_group] end def any_hook(event)