nice logging

examples/ldapdb.yaml

@@ -1,7 +1,17 @@
 ---
-dc=pvincent,dc=re:
+
+dc=zourit,dc=re:
   cn:
   - Top object
+
+mail=pvincent@artcode.re,dc=zourit,dc=re:
+  cn:
+  - pvincent
+  sn:
+  - Philippe Vincent BETA
+  mail:
+  - pvincent@artcode.re
+
 mail=admin@pvincent.re,dc=zourit,dc=re:
   cn:
   - admin
@@ -9,6 +19,7 @@ mail=admin@pvincent.re,dc=zourit,dc=re:
   - Vincentdmin
   mail:
   - admin@pvincent.re
+
 mail=test1@pvincent.re,dc=zourit,dc=re:
   cn:
   - test1
@@ -16,6 +27,7 @@ mail=test1@pvincent.re,dc=zourit,dc=re:
   - Test1
   mail:
   - test1@pvincent.re
+
 mail=test2@pvincent.re,dc=zourit,dc=re:
   cn:
   - test2
@@ -23,6 +35,7 @@ mail=test2@pvincent.re,dc=zourit,dc=re:
   - Test2
   mail:
   - test2@pvincent.re
+
 mail=test3@pvincent.re,dc=zourit,dc=re:
   cn:
   - test3

examples/server2.rb

@@ -1,62 +1,71 @@
 #!/usr/bin/env ruby
 
-$:.unshift('lib')
+$LOAD_PATH.unshift('lib')
-$debug = true
-
 require 'ldap/server'
 
-$logger = Logger.new($stderr)
+LOGGER = Logger.new($stderr)
-# We subclass the Operation class, overriding the methods to do what we need
 
+# We subclass the Operation class, overriding the methods to do what we need
 class HashOperation < LDAP::Server::Operation
-  def initialize(connection, messageID, hash)
+  def initialize(connection, message_id, hash)
-    super(connection, messageID)
+    super(connection, message_id)
-    @hash = hash # an object reference to our directory data
+    @hash = hash
   end
 
   # ici, c'est bizarre
   # systèmatiquement appelé (SEARCH ou AUTH)
   # du coup, je retourne super si pas de dn => SEARCH normal sans authentication
   # sinon ça passe aussi !!!
-  def do_bind(protocolOp, controls) # :nodoc:
+  def do_bind(operation, _controls)
-    dn = protocolOp.value[1].value
+    dn = operation.value[1].value
     dn = nil if dn == ''
     return super if dn.nil?
 
-    version = protocolOp.value[0].value
+    password = operation.value[2].value
-    authentication = protocolOp.value[2]
+    email = extract_mail_from_dn(dn)
-    password = authentication.value
+    authenticated = valid?(email, password)
-    valid = password == 'toto'
+    LOGGER.info("AUTHENTICATION email=#{email} => #{authenticated}")
-    $logger.info("AUTHENTICATION ..version=#{version}, dn=#{dn}, valid=#{valid}")
+    send_BindResponse(authenticated ? 0 : 1)
-    send_BindResponse(valid ? 0 : 1)
+  end
+
+  def extract_mail_from_dn(entry)
+    entry[/mail=(.*?),/, 1] # short for regex first capture
+  end
+
+  def valid?(_email, password)
+    password == 'toto'
   end
 
   def search(basedn, scope, deref, filter)
-    $logger.info("SEARCHING...basedn=#{basedn}, scope=#{scope}, deref=#{deref}, filter=#{filter}")
-
     basedn = basedn.downcase
-    nil
+    LOGGER.info("SEARCHING...basedn=\"#{basedn}\", scope=#{scope}, deref=#{deref}, filter=#{filter}")
     case scope
     when LDAP::Server::BaseObject
       # client asked for single object by DN
       obj = @hash[basedn]
       raise LDAP::ResultError::NoSuchObject unless obj
 
-      $logger.info('BaseObject')
+      if LDAP::Server::Filter.run(filter, obj)
-      send_SearchResultEntry(basedn, obj) if LDAP::Server::Filter.run(filter, obj)
+        LOGGER.info("1 Base Found: #{obj}")
+        send_SearchResultEntry(basedn, obj)
+      end
     when LDAP::Server::WholeSubtree
+      found = 0
       @hash.each do |dn, av|
         next unless dn.index(basedn, -basedn.length) # under basedn?
         next unless LDAP::Server::Filter.run(filter, av) # attribute filter?
 
-        $logger.info("WholeSubtree av=#{av}")
+        found += 1
+        LOGGER.info("Found Filtered #{av}")
         send_SearchResultEntry(dn, av)
       end
+      found = 'NO' if found == 0
+      LOGGER.info("#{found} items found")
 
     else
       raise LDAP::ResultError::UnwillingToPerform, 'OneLevel not implemented'
-
     end
+    send_SearchResultDone(0)
   end
 end
 
@@ -66,11 +75,10 @@ end
 directory = {}
 require 'yaml'
 File.open('examples/ldapdb.yaml') { |f| directory = YAML.load(f.read) }
-$logger.info("DIRECTORY=#{directory}")
+LOGGER.info("DIRECTORY=#{directory}")
 
 # Listen for incoming LDAP connections. For each one, create a Connection
 # object, which will invoke a HashOperation object for each request.
-
 s = LDAP::Server.new(
   port: 1389,
   nodelay: true,
@@ -79,6 +87,6 @@ s = LDAP::Server.new(
   operation_args: [directory]
 )
 
-$logger.info('server2 RUNNING...')
+LOGGER.info('Ready to perform LDAP operations...')
 s.run_tcpserver
 s.join